Update protobuf to v25.1 #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RReichert
force-pushed
the
rodrigor/upgrade-grpc
branch
from
510ab70 to
ffc960a
Compare
sbmueller
reviewed
May 7, 2025
| # The whole codebase should build with c++14 | ||
| "-std=c++14", | ||
| ] | ||
| cxx_flags = select({ |
There was a problem hiding this comment.
How does this compare to https://github.com/swift-nav/rules_swiftnav/blob/main/cc/defs.bzl#L62 ? I actually wasn't aware of the flag directly in the toolchain file.
There was a problem hiding this comment.
with what is highlighted here, if you use the bazel cc_library or cc_binary directly it will impose the "global cxx standard". in the code snippet that you posted, that only applies to swift_cc_library and swift_cc_binary targets and overrules the global setting.
sbmueller
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I'm adding a new build flag which controls what C++ version it will use across the entire codebase, including third party libraries. By default Bazel uses C++14 (implicitly, even in third party libraries), which normally won't be a problem if it wasn't for the fact that the newest protobuf library which we are introducing didn't have have a problem with this, specifically Abseil.
Repositories can now run:
Which compiles everything with the C++17 standard. Options for C++20 and C++23 have been added as well.